SIP-200: Fix FeePool Rewards Distribution
|Network||Ethereum & Optimism|
|Implementor||Mark E. Barrasso (@barrasso)|
Fix the FeePool contract such that only correctly authorized addresses can call
This update will fix the authorization logic on the
setRewardsToDistribute function by properly implementing the legacy proxy system.
The current authorization logic for the
setRewardsToDistribute method can be circumvented due to an incomplete implementation. This resolves the issue.
We can apply the
optionalProxy modifier to the
setRewardsToDistribute function, such that the
messageSender value is appropriately updated.
The existing implementation would allow the function to execute if
messageSender (in addition to
msg.sender) were set to
messageSender may be using a stale value because the
optionalProxy modifier hasn't been applied to the
This SIP has no implications for the public interface of Synthetix.
A unit test has been added to the relevant pull request for this SIP.
Configurable Values (Via SCCP)
Copyright and related rights waived via CC0.